linux-kernel - Re: [PATCH] gpio: New driver for the Intel 82801 (ICH) GPIO pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110419180829.56daccd0@lxorguk.ukuu.org.uk>
Date:	Tue, 19 Apr 2011 18:08:29 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Jean Delvare <khali@...ux-fr.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Jamie Iles <jamie@...ieiles.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>, arnd@...db.de
Subject: Re: [PATCH] gpio: New driver for the Intel 82801 (ICH) GPIO pins

> How about exporting some bus/device-type neutral probe function, like
> we do in drivers/ata/pata_platform.c ?

Not sure you want to be using resources as the basic currency, nor do you
want your generic code doing the request_region stuff. That was a nasty
mistake we made in the IDE code.

Maybe the platform code should do that bit, but the generic stuff not - in
the PCI case the caller will have done pci_request_* itself and chances
are several of the resources are the same pci device resource and
different offsets so doing request_resource on them will blow up.

Concept looks good

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/