linux-kernel - Re: [PATCH] gpio: New driver for the Intel 82801 (ICH) GPIO pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110419222032.6529bd31@lxorguk.ukuu.org.uk>
Date:	Tue, 19 Apr 2011 22:20:32 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Anton Vorontsov <cbouatmailru@...il.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Jean Delvare <khali@...ux-fr.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Jamie Iles <jamie@...ieiles.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>, arnd@...db.de
Subject: Re: [PATCH] gpio: New driver for the Intel 82801 (ICH) GPIO pins

> > I.e. PCI driver can now map the whole area with a single ioremap(),
> > and then call bgpio_probe(), which will provide accessors and
> > common MMIO GPIO registration stuff.
> 
> Looks sane and providing its all using iomap/ioread/iowrite it covers all
> cases nicely.

Actually not using iomap makes more sense on second thoughts, not all
platforms have a generic iomap implementation.

So yes this all looks good.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/