linux-kernel - Re: [PATCH] leds: provide helper to register "leds-gpio" devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Apr 2011 16:19:13 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	Richard Purdie <rpurdie@...ys.net>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	H Hartley Sweeten <hartleys@...ionengravers.com>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Sascha Hauer <s.hauer@...gutronix.de>, kernel@...gutronix.de
Subject: Re: [PATCH] leds: provide helper to register "leds-gpio" devices

On Tue, 5 Apr 2011 17:33:39 +0100
Russell King - ARM Linux <linux@....linux.org.uk> wrote:

> On Tue, Apr 05, 2011 at 10:37:35AM +0200, Uwe Kleine-K__nig wrote:
> > +struct platform_device *__init gpio_led_register_device(
> > +		const struct gpio_led_platform_data *pdata);
> 
> Please don't add __init annotations to declarations.

Reasons?

A year or so ago we had to *add* an __init to a declaration, because
one architecture was generating a short-mode-addressing relative branch
to the callee, assuming the target was in the same section as the call
site.  When the linker went to resolve the branch, it discovered that
the target was in fact in a different section and was too far away to
be able to use the short-mode addressing.  IIRC, that architecture was
arm.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/