linux-kernel - RE: [PATCH 2/6] dmaengine/dw_dmac: Enable resubmission from callback routine.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <438BB0150E931F4B9CE701519A44630108519E1BE6@bgsmsx502.gar.corp.intel.com>
Date:	Tue, 19 Apr 2011 11:42:24 +0530
From:	"Koul, Vinod" <vinod.koul@...el.com>
To:	Viresh Kumar <viresh.kumar@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Williams, Dan J" <dan.j.williams@...el.com>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"armando.visconti@...com" <armando.visconti@...com>,
	"shiraz.hashim@...com" <shiraz.hashim@...com>,
	"amit.goel@...com" <amit.goel@...com>,
	"viresh.linux@...il.com" <viresh.linux@...il.com>,
	"jamie@...ieiles.com" <jamie@...ieiles.com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>
Subject: RE: [PATCH 2/6] dmaengine/dw_dmac: Enable resubmission from
 callback routine.

On 04/18/2011 04:20 PM, viresh kumar wrote:
> 
> Resubmission of new transfer must be allowed from callbacks. For this release
> lock before calling callback routine and enable them again.
Why would you like to do that?

IMO it's not a good thing as you are essentially doing it in your tasklet...
Make sure the submit() is done by client before this and you use it to start
next transaction in you tasklet and let client know in callback txn is
finished.

~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/