lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Apr 2011 11:55:45 +0530 From: viresh kumar <viresh.kumar@...com> To: "vinod.koul@...el.com" <vinod.koul@...el.com>, "dan.j.williams@...el.com" <dan.j.williams@...el.com> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Armando VISCONTI <armando.visconti@...com>, Shiraz HASHIM <shiraz.hashim@...com>, amitgoel <amit.goel@...com>, "viresh.linux@...il.com" <viresh.linux@...il.com>, "jamie@...ieiles.com" <jamie@...ieiles.com>, "linux@....linux.org.uk" <linux@....linux.org.uk> Subject: Re: [PATCH 1/6] dmaengine/dw_dmac: Replace spin_lock_bh with irqsave variants On 04/18/2011 04:19 PM, Viresh KUMAR wrote: > dmaengine routines can be called from interrupt context and with interrupts > disabled. Whereas spin_unlock_bh can't be called from such contexts. So this > patch converts all spin_*_bh routines to irqsave variants. > > Signed-off-by: Viresh Kumar <viresh.kumar@...com> > --- > drivers/dma/dw_dmac.c | 56 +++++++++++++++++++++++++------------------ > drivers/dma/dw_dmac_regs.h | 1 + > 2 files changed, 33 insertions(+), 24 deletions(-) > > > diff --git a/drivers/dma/dw_dmac_regs.h b/drivers/dma/dw_dmac_regs.h > index 720f821..c89fd83 100644 > --- a/drivers/dma/dw_dmac_regs.h > +++ b/drivers/dma/dw_dmac_regs.h > @@ -173,6 +173,7 @@ struct dw_dma { > void __iomem *regs; > struct tasklet_struct tasklet; > struct clk *clk; > + unsigned long flags; /* for spin_lock_irqsave */ Oops!!! This must have been added in dw_dma_chan instead :( Will resend it. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists