linux-kernel - Re: [PATCH 3/7] Char: nozomi, remove useless tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4DAEAD94.6070304@fastmail.fm>
Date:	Wed, 20 Apr 2011 10:55:32 +0100
From:	Jack Stone <jwjstone@...tmail.fm>
To:	Jiri Slaby <jslaby@...e.cz>
CC:	gregkh@...e.de, jirislaby@...il.com, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, Alan Cox <alan@...ux.intel.com>
Subject: Re: [PATCH 3/7] Char: nozomi, remove useless tty_sem

On 20/04/2011 09:43, Jiri Slaby wrote:
> tty_sem used to protect tty open count. This was removed in 33dd474a
> but the lock remained in place.
> 
> So remove it completely as it protects nothing now.
> 
> Also this solves Mac's problem with inatomic operation called from
> atomic context (ppp):
> BUG: scheduling while atomic: firefox-bin/1992/0x10000800
> Modules linked in: ...
> Pid: 1992, comm: firefox-bin Not tainted 2.6.38 #1
> Call Trace:
> ...
>  [] ? mutex_lock+0xe/0x21
>  [] ? ntty_write+0x5d/0x192 [nozomi]
>  [] ? __mod_timer.clone.30+0xbe/0xcc
>  [] ? check_preempt_curr+0x60/0x6d
>  [] ? __nf_ct_refresh_acct+0x75/0xbe
>  [] ? ppp_async_push+0xa9/0x3bd [ppp_async]
>  [] ? ppp_async_send+0x34/0x40 [ppp_async]
>  [] ? ppp_push+0x6c/0x4f9 [ppp_generic]
> ...
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Reported-by: Mac <kmac@...zta.fm>
> Tested-by: Gerald Pfeifer <gerald@...ifer.com>
> Cc: Jack Stone <jwjstone@...tmail.fm>
Reviewed-by: Jack Stone <jwjstone@...tmail.fm>
> Cc: Alan Cox <alan@...ux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@...e.de>

Thanks for sorting this Jiri.

Jack
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/