linux-kernel - Re: [PATCH] HID: add support for PenMount dual-touch panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Apr 2011 12:07:59 +0200
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	Benjamin Tissoires <benjamin.tissoires@...c.fr>
Cc:	Richard Nauber <richard.nauber@...glemail.com>,
	PenMount <penmount.touch@...il.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Stephane Chatty <chatty@...-enac.fr>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	PenMount <salt@...t.com.tw>
Subject: Re: [PATCH] HID: add support for PenMount dual-touch panel

> > Benjamin: Since field->index == 0 is in use, it seems the driver could
> > execute event emission wrongly under some circumstances (when
> > last_field_index == 0). Is that related to the reason for the quirk in
> > this patch?
> 
> In fact, I have a second patch just on top of this one. It has been
> tested by Ryan with PenMount devices.

Great, and good timing. :-)

> I was waiting for Penmount to be included first as it does not impact
> any other drivers.

I would prefer the opposite order, since it is cleaner and means one
less device to test for the major change.

> 
> I inline the code here, but my gmail client will destroy tabs (so I
> attached it too)....
> 
> Can you test it against 3M?

I will test it against 3M and egalax. Thanks!

Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/