linux-kernel - Re: [PATCH] fs: bound mount propagation fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DAEC8BB.9040809@nokia.com>
Date:	Wed, 20 Apr 2011 15:51:23 +0400
From:	Roman Borisov <ext-roman.borisov@...ia.com>
To:	ext Andrew Morton <akpm@...ux-foundation.org>
CC:	viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org,
	vda.linux@...glemail.com, cebbert@...hat.com, virtuoso@...nd.org
Subject: Re: [PATCH] fs: bound mount propagation fix

On 04/20/2011 01:04 AM, ext Andrew Morton wrote:
> On Fri,  1 Apr 2011 18:48:20 +0400
> Roman Borisov<ext-roman.borisov@...ia.com>  wrote:
>
>> I think MS_SILENT shouldn't be cleared anywhere. I suppose the bug is in
>> MS_SHARED options checking. Please see the patch below.
>>
>> Fixed MS_SHARED, MS_SLAVE, MS_UNBINDABLE option handling;
>> Existing options check doesn't allow to have any options combinations
>> because of integer comparison (not bitwise).
>>
>
> (when fixing a bug, please include a *complete* description of that bug
> in the changelog.  It should include a description of the user-visible
> misbehaviour and a description of the coding error).
>
>
> The vfs code is pretty confusing about whether `type' is supposed to be
> a scalar or a bitfield.
>
> flags_to_propagation_type() has that is_power_of-two() check in there
> to reject more-than-one-bit-set.
>

Thanks for comment.
I tested the patch on too old kernel which doesn't contain is_power_of_2 
checking in do_change_type.
I'll post patch_v2 recently.

--
Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/