linux-kernel - Re: [PATCH] perf, nmi: Move LVT un-masking into irq handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4DAEF5A6.4040405@gmail.com>
Date:	Wed, 20 Apr 2011 19:03:02 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Don Zickus <dzickus@...hat.com>
CC:	x86@...nel.org, Peter Zijlstra <peterz@...radead.org>,
	Robert Richter <robert.richter@....com>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] perf, nmi: Move LVT un-masking into irq handlers

On 04/20/2011 06:57 PM, Don Zickus wrote:
> On Wed, Apr 20, 2011 at 06:37:10PM +0400, Cyrill Gorcunov wrote:
>> Don, sorry for delay, I somehow missed this patch at first place :/ And probably
>> the patch below could help with "stess" problem?
> 
> The patch I am using for the 'stress' problem is different than what I
> posted because I wanted to keep it simple for 2.6.39.  But yeah I already
> moved the unmasking to the enable_pmus_all(0) line.

ok

> 
> The thing is that cuts down on some of these in-flight NMIs but not all of
> them.  I came up with some logic that catches all the in-flight NMIs on
> Nehalem and AMDs but my core2quad still fails.  I'll try to post that
> today while requesting help.

ok

> 
> Still not sure you need the double APIC writes (as your patch) shows.  I
> haven't seen a case in my testing where a single APIC write fails.

yup, we can drop it, thanks!

> 
> Cheers,
> Don

-- 
    Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/