linux-kernel - Re: [PATCH] ALSA: hda - Fix unused warnings when !SND_HDA_NEEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hr58wiv33.wl%tiwai@suse.de>
Date:	Wed, 20 Apr 2011 21:25:20 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Mike Waychison <mikew@...gle.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org,
	Raymond Yau <superquad.vortex2@...il.com>,
	David Henningsson <david.henningsson@...onical.com>,
	Luke Yelavich <luke.yelavich@...onical.com>
Subject: Re: [PATCH] ALSA: hda - Fix unused warnings when !SND_HDA_NEEDS_RESUME

At Wed, 20 Apr 2011 12:04:36 -0700,
Mike Waychison wrote:
> 
> When SND_HDA_NEEDS_RESUME is not defined, the compiler identifies that
> the following symbols are static but not used:
> 
>  restore_shutup_pins
>  hda_cleanup_all_streams
> 
> Fix warnings by adding SND_HDA_NEEDS_RESUME guards.
> 
> Signed-off-by: Mike Waychison <mikew@...gle.com>

Applied now.  Thanks!


Takashi

> ---
> v2:
> - Applies to v2.6.39-rc4.
> - Dropped moving ad198x_power_eapd and ad198x_power_eapd_write at
>   Takashi Iwai <tiwai@...e.de>'s request.
> ---
>  sound/pci/hda/hda_codec.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
> index 430f41d..759ade1 100644
> --- a/sound/pci/hda/hda_codec.c
> +++ b/sound/pci/hda/hda_codec.c
> @@ -937,6 +937,7 @@ void snd_hda_shutup_pins(struct hda_codec *codec)
>  }
>  EXPORT_SYMBOL_HDA(snd_hda_shutup_pins);
>  
> +#ifdef SND_HDA_NEEDS_RESUME
>  /* Restore the pin controls cleared previously via snd_hda_shutup_pins() */
>  static void restore_shutup_pins(struct hda_codec *codec)
>  {
> @@ -953,6 +954,7 @@ static void restore_shutup_pins(struct hda_codec *codec)
>  	}
>  	codec->pins_shutup = 0;
>  }
> +#endif
>  
>  static void init_hda_cache(struct hda_cache_rec *cache,
>  			   unsigned int record_size);
> @@ -1329,6 +1331,7 @@ static void purify_inactive_streams(struct hda_codec *codec)
>  	}
>  }
>  
> +#ifdef SND_HDA_NEEDS_RESUME
>  /* clean up all streams; called from suspend */
>  static void hda_cleanup_all_streams(struct hda_codec *codec)
>  {
> @@ -1340,6 +1343,7 @@ static void hda_cleanup_all_streams(struct hda_codec *codec)
>  			really_cleanup_stream(codec, p);
>  	}
>  }
> +#endif
>  
>  /*
>   * amp access functions
> -- 
> 1.7.3.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/