linux-kernel - Re: [PATCH] drivers/acpi/utils.c: Fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110421102815.5abf133e@absol.kitzblitz>
Date:	Thu, 21 Apr 2011 10:28:15 +0200
From:	Nicolas Kaiser <nikai@...ai.net>
To:	Karthigan Srinivasan <karthigan.srinivasan@...com>
Cc:	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/acpi/utils.c: Fixed coding style issues

* Karthigan Srinivasan <karthigan.srinivasan@...com>:
> Fixed brace and comment coding style issues in code.
> 
> Signed-off-by: Karthigan Srinivasan <karthigan.srinivasan@...com>
> ---
>  drivers/acpi/utils.c |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
> index b002a47..2cf81a1 100644
> --- a/drivers/acpi/utils.c
> +++ b/drivers/acpi/utils.c
> @@ -99,9 +99,9 @@ acpi_extract_package(union acpi_object *package,
>  
>  		union acpi_object *element = &(package->package.elements[i]);
>  
> -		if (!element) {
> +		if (!element) 
                             ^
You are introducing trailing whitespace.

>  			return AE_BAD_DATA;
> -		}
> +		
   ^^^^^^^^^^^^^
For every pair of braces you clean away, you're adding
two new coding style issues.

Best regards,
Nicolas Kaiser
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/