linux-kernel - Re: annoying new gcc 4.6.0 warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DB09590.1040709@caviumnetworks.com>
Date:	Thu, 21 Apr 2011 13:37:36 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	Dave Jones <davej@...hat.com>, Sam Ravnborg <sam@...nborg.org>,
	Joe Perches <joe@...ches.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	BorislavPetkov <bp@...en8.de>
Subject: Re: annoying new gcc 4.6.0 warnings.

On 04/21/2011 01:27 PM, Dave Jones wrote:
> On Thu, Apr 21, 2011 at 10:08:36PM +0200, Sam Ravnborg wrote:
>
>   >  My gcc (4.3.2) barfed over -Wno-unused-but-set-variable.
>   >  So your patch needs to check if the option is supported.
>
> I don't have a gcc older than 4.4.0. Can you try this ?
>
> 	Dave
> --
>
> Disable the new -Wunused-but-set-variable that was added in gcc 4.6.0
> It produces more false positives than useful warnings.
>
> This can still be enabled using W=1
>
> Signed-off-by: Dave Jones<davej@...hat.com>
>
> diff --git a/Makefile b/Makefile
> index b967b96..29e16f2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -559,6 +559,8 @@ ifndef CONFIG_CC_STACKPROTECTOR
>   KBUILD_CFLAGS += $(call cc-option, -fno-stack-protector)
>   endif
>
> +KBUILD_CFLAGS += $(call cc-option, -Wno-unused-but-set-variable)
> +
>   ifdef CONFIG_FRAME_POINTER
>   KBUILD_CFLAGS	+= -fno-omit-frame-pointer -fno-optimize-sibling-calls
>   else
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index d5f925a..30627ab 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -79,6 +79,7 @@ KBUILD_EXTRA_WARNINGS += -Wpointer-arith
>   KBUILD_EXTRA_WARNINGS += -Wredundant-decls
>   KBUILD_EXTRA_WARNINGS += -Wshadow
>   KBUILD_EXTRA_WARNINGS += -Wswitch-default
> +KBUILD_EXTRA_WARNINGS += -Wunused-but-set-variable

Well I didn't test it, but presumably if you need the $(call cc-option, 
-Wno-unused-but-set-variable), you would need similar here.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/