linux-kernel - Re: annoying new gcc 4.6.0 warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110421205612.GA4541@merkur.ravnborg.org>
Date:	Thu, 21 Apr 2011 22:56:12 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Dave Jones <davej@...hat.com>,
	David Daney <ddaney@...iumnetworks.com>,
	Joe Perches <joe@...ches.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	BorislavPetkov <bp@...en8.de>
Subject: Re: annoying new gcc 4.6.0 warnings.

On Thu, Apr 21, 2011 at 04:45:49PM -0400, Dave Jones wrote:
> On Thu, Apr 21, 2011 at 01:37:36PM -0700, David Daney wrote:
>  > > +KBUILD_EXTRA_WARNINGS += -Wunused-but-set-variable
>  > 
>  > Well I didn't test it, but presumably if you need the $(call cc-option, 
>  > -Wno-unused-but-set-variable), you would need similar here.
>  
> Third time's the charm ?

Seems soo. It semi works now.
"make W=1" is broken for reasons that is not related to this patch - will submit
a fix in a minute for that.

So you can add:
Acked-by: Sam Ravnborg <sam@...nborg.org>
Tested-by: Sam Ravnborg <sam@...nborg.org>

on the patch.

And if you really want to make me happy then you add a comment about _why_
we disable the warning.

Something like:

# This warning generated too much noise in a regular build.
# Use make W=1 to enable this warning (see scripts/Makefile.build)
+KBUILD_CFLAGS += $(call cc-option, -Wno-unused-but-set-variable)
+
 ifdef CONFIG_FRAME_POINTER


	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/