linux-kernel - [PATCH] kbuild: fix W=1 with gcc 4.3.2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110421210852.GA6196@merkur.ravnborg.org>
Date:	Thu, 21 Apr 2011 23:08:52 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Michal Marek <mmarek@...e.cz>,
	linux-kbuild <linux-kbuild@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Dave Jones <davej@...hat.com>
Subject: [PATCH] kbuild: fix W=1 with gcc 4.3.2

Building a kernel using W=1 with gcc 4.3.2 failed like this:

    cc1: error: unrecognized command line option "-Wpacked-bitfield-compat"

Make use of this option dependent on the compiler.

Signed-off-by: Sam Ravnborg <sam@...nborg.org>
Cc: Dave Jones <davej@...hat.com>
---
I do not see this a stable material - people running stable kernels
have less value of W=1.

And the amount of warnings are outright silly. We should really
divide this up a bit so W=1 is semi usefull.

	Sam

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index d5f925a..b280284 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -73,7 +73,7 @@ KBUILD_EXTRA_WARNINGS += -Wnested-externs
 KBUILD_EXTRA_WARNINGS += -Wold-style-definition
 KBUILD_EXTRA_WARNINGS += $(call cc-option, -Woverlength-strings,)
 KBUILD_EXTRA_WARNINGS += -Wpacked
-KBUILD_EXTRA_WARNINGS += -Wpacked-bitfield-compat
+KBUILD_EXTRA_WARNINGS += $(call cc-option, -Wpacked-bitfield-compat)
 KBUILD_EXTRA_WARNINGS += -Wpadded
 KBUILD_EXTRA_WARNINGS += -Wpointer-arith
 KBUILD_EXTRA_WARNINGS += -Wredundant-decls
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/