linux-kernel - Re: [PATCH] xen block backend driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110421034016.GB11501@infradead.org>
Date:	Wed, 20 Apr 2011 23:40:16 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:	jaxboe@...ionio.com, linux-kernel@...r.kernel.org,
	xen-devel@...ts.xensource.com, konrad@...nel.org
Subject: Re: [PATCH] xen block backend driver.

> +#define WRITE_BARRIER	(REQ_WRITE | REQ_FLUSH | REQ_FUA)

Any in case you want to keep usingthis POS out of tree you really need
to fix this.  REQ_FLUSH | REQ_FUA is not equivalent to the old barrier
semantics that the Xen disk protocol exported to the guest.  You need
to drain the whole queue of outstanding I/Os as some old guest (at least
those using reiserfs, e.g. old SLES) rely on it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/