linux-kernel - Re: [PATCH] powerpc: stop exporting irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTimYJu5BeCb3i64KVTDcTn8SnFsPXQ@mail.gmail.com>
Date:	Wed, 20 Apr 2011 21:58:53 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	benh@...nel.crashing.org, linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc: stop exporting irq_map

On Wed, Apr 20, 2011 at 1:31 PM, Sam Ravnborg <sam@...nborg.org> wrote:
>> +
>>  irq_hw_number_t virq_to_hw(unsigned int virq)
>>  {
>>       return irq_map[virq].hwirq;
>>  }
>>  EXPORT_SYMBOL_GPL(virq_to_hw);
>
> General comment...
> kernel/irq/* denote the virtual irq numbers "irq".
> powerpc uses "virq" for the same.

I might do that, but I'm early in this refactoring work yet so I'm not
entirely sure what the final result is going to look like.  At least
with the 'virq_' prefix I can find the powerpc specific functions that
are candidates for refactoring or replacing.

g.

>
> Sometimes it is confusing that two different names is used
> for the same thing.
>
> The intent of this patch is to centralize access to a common data structure,
> but this could also be a good candidate for a terminology shift if
> this is considered.
>
> "git grep virq" shows a lot of hits - especially in arm, powerpc.
> So what I suggest is obviously only a small step in the direction
> of using "irq" all over.
>
>        Sam
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/