linux-kernel - RE: [PATCH 2.6.39-rc3] i2c-i801: SMBus patch for Intel Panther Point DeviceIDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CF9C39F99A89134C9CF9C4CCB68B8DDF25DCDE2DBA@orsmsx501.amr.corp.intel.com>
Date:	Fri, 22 Apr 2011 09:47:34 -0700
From:	"Heasley, Seth" <seth.heasley@...el.com>
To:	Jean Delvare <khali@...ux-fr.org>
CC:	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: RE: [PATCH 2.6.39-rc3] i2c-i801: SMBus patch for Intel Panther
 Point DeviceIDs

Hi Jean,

>With each new chip, we have to add the SMBus device ID to pci_ids.h,
>then wait for Jesse to merge that, and only then I can apply the
>changes to i2c-i801.c. This approach slows things down needlessly.
>
>It isn't mandatory to add IDs to pci_ids.h when an ID is only used
>locally in a device driver. So what I would like to propose is that we
>move all PCI_DEVICE_ID_INTEL_*_SMBUS declarations from pci_ids.h to
>i2c-i801.c now. Then you can resubmit your Panther Point patches, and
>the pci and i2c parts will be independent, so Jesse and myself don't
>depend on each other to apply them.
>
>Seth, if you agree, I can take care of the move, or you can send a
>patch doing that, whatever you prefer.

I've been thinking about this one myself, and I tend to agree.  It'd probably be simpler if you went ahead and made the changes, and I'll be happy to review them.

-Seth
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/