| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4DB1BD96.9090205@bitwagon.com> Date: Fri, 22 Apr 2011 10:40:38 -0700 From: John Reiser <jreiser@...wagon.com> To: Steven Rostedt <rostedt@...dmis.org> CC: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>, Andrew Morton <akpm@...ux-foundation.org>, Frederic Weisbecker <fweisbec@...il.com>, "H. Peter Anvin" <hpa@...or.com> Subject: Re: [RFC][PATCH 01/11] ftrace/trivial: Clean up recordmcount.c to use Linux style comparisons On 04/22/2011 09:13 AM, Steven Rostedt wrote: > Although, I have no idea why you choose the 0 < var, that totally > confuses me. It does not play any role in assignments. What bug is that > preventing? When I want to know if a variable is greater than zero, I > don't show it as zero less than the var. Using ">" can be confused visually with "->", and I want to reduce those chances. I also prefer a style that is prefix oriented, and with constants on the left. I mentally combine the left constant and the infix operator into a special case prefix operator. This speeds my parsing because it reduces stack depth and enables faster scanning. This is particularly helpful when the constant is narrow and the other operand is wider. -- John Reiser -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists