linux-kernel - Re: [PATCH] export kernel call get_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1104221534380.3873@chino.kir.corp.google.com>
Date:	Fri, 22 Apr 2011 15:35:57 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	james_p_freyensee@...ux.intel.com
cc:	akpm@...ux-foundattion.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org, suhail.ahmed@...el.com,
	christophe.guerard@...el.com
Subject: Re: [PATCH] export kernel call get_task_comm().

On Fri, 22 Apr 2011, james_p_freyensee@...ux.intel.com wrote:

> From: J Freyensee <james_p_freyensee@...ux.intel.com>
> 
> This allows drivers who call this function to be compiled modularly.
> Otherwise, a driver who is interested in this type of functionality
> has to implement their own get_task_comm() call, causing code
> duplication in the Linux source tree.
> 
> Signed-off-by: J Freyensee <james_p_freyensee@...ux.intel.com>

Acked-by: David Rientjes <rientjes@...gle.com>

I still suggest that we implement finer-grained protection for tsk->comm 
through get_task_comm(), though, because it's going to be difficult to 
know whether task_lock(tsk) is held in all contexts we'll want to call it; 
task_lock(tsk) is used to protect many members of task_struct.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/