linux-kernel - Re: [PATCH 1/2] HID: hid-multitouch: refactor last_field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1104221154540.12035@pobox.suse.cz>
Date:	Fri, 22 Apr 2011 11:55:34 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	Benjamin Tissoires <benjamin.tissoires@...c.fr>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Stephane Chatty <chatty@...-enac.fr>,
	PenMount <penmount.touch@...il.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] HID: hid-multitouch: refactor last_field_index

On Thu, 21 Apr 2011, Henrik Rydberg wrote:

> > the current implementation requires the devices to report
> > HID_DG_CONTACTCOUNT to set the last_field_index value.
> > However, devices reporting in serial mode (DWAV and PenMount)
> > do not send this field.
> > Other devices (3M) add other fields in the reports descriptor
> > that are not multitouch related at the end, thus the need to
> > add a special case in the default case when handling events.
> > 
> > A first work around has been set up but with PenMount devices,
> > we have reached the limit.
> > 
> > The idea is to calculate the last_field_index by relying only on
> > multitouch fields the device send. This allows us to remove
> > the handling of non-multitouch events in hid-multitouch, and
> > guarantee that the function mt_emit_event is always called.
> > 
> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...c.fr>
> > ---
> 
> Reviewed-and-tested-by: Henrik Rydberg <rydberg@...omail.se>

Applied, thanks guys.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/