linux-kernel - Re: [TRIVIAL PATCH] treewide: Cleanup continuations and remove logging message whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110425082230.6d656ed0.randy.dunlap@oracle.com>
Date:	Mon, 25 Apr 2011 08:22:30 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Jiri Kosina <trivial@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [TRIVIAL PATCH] treewide: Cleanup continuations and remove
 logging message whitespace

On Sat, 23 Apr 2011 20:38:19 -0700 Joe Perches wrote:

> Using C line continuation inside format strings is error prone.
> Clean up the unintended whitespace introduced by misuse of \.
> Neaten correctly used line continations as well for consistency.
> 
> drivers/scsi/arcmsr/arcmsr_hba.c has these errors as well,
> but arcmsr needs a lot more work and the driver should likely be
> moved to staging instead.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

> ---
>  arch/arm/plat-mxc/cpufreq.c                     |    4 +-
>  drivers/dma/dmatest.c                           |    4 +-
>  drivers/firmware/iscsi_ibft.c                   |    4 +-
>  drivers/gpio/ab8500-gpio.c                      |    7 ++---
>  drivers/media/video/usbvision/usbvision-video.c |    5 ++-
>  drivers/message/fusion/mptbase.c                |   22 ++++++++----------
>  drivers/misc/bh1780gli.c                        |    8 +++---
>  drivers/misc/spear13xx_pcie_gadget.c            |    4 +-
>  drivers/net/atlx/atl1.c                         |    5 ++-
>  drivers/net/wireless/airo.c                     |   27 ++++++++++++-----------
>  drivers/net/wireless/iwlegacy/iwl-4965-calib.c  |    4 +-
>  drivers/net/wireless/iwlwifi/iwl-agn-calib.c    |    4 +-
>  drivers/regulator/max8998.c                     |    4 +-
>  drivers/tty/serial/bfin_sport_uart.c            |    3 +-
>  drivers/tty/serial/mfd.c                        |    4 +-
>  drivers/usb/host/uhci-hcd.c                     |    7 +++--
>  drivers/usb/storage/ene_ub6250.c                |    4 +-
>  17 files changed, 60 insertions(+), 60 deletions(-)


Joe,
Is there a decent fix for this warning in linux-next:

drivers/tty/n_gsm.c:535: warning: zero-length gnu_printf format string

thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/