linux-kernel - Re: w1 driver for omap error -- reversed byte sequence in netlink slave message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110424230536.a77c9366.akpm@linux-foundation.org>
Date:	Sun, 24 Apr 2011 23:05:36 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Paul Alfille <paul.alfille@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Evgeniy Polyakov <johnpol@....mipt.ru>
Subject: Re: w1 driver for omap error -- reversed byte sequence in netlink
 slave message

On Thu, 21 Apr 2011 21:53:39 -0400 Paul Alfille <paul.alfille@...il.com> wrote:

> OWFS (one-wire filesystem -- www.owfs.org) seems to be the only user
> of the w1 netlink messages. We use them to extend the kernel 1-wire
> system from a simple temperature sensor to a complete 1-wire bus
> master. Thus we've uncovered a bug -- byte reversal -- in one of the
> sub-modules.
> 
> 1-wire devices have a unique 64-bit address (including an 8-bit CRC)
> that is reported by the netlink W1_CMD_SEARCH message. For the omap
> bus master, and only the omap bus master, the slave addresses are
> byte-order reversed. If the slave byte order is reversed in that case,
> the CRC8 is then correct, the slave address then matches the actual
> device address lettered on the device, and all other commands work
> correctly.
> 
> The driver is in kernel/drivers/w1/masters/omap_hdq.c
> 

Have you fixed it?  Can you send us a tested patch to look at?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/