[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110425110321.GF17734@mtj.dyndns.org>
Date: Mon, 25 Apr 2011 13:03:21 +0200
From: Tejun Heo <tj@...nel.org>
To: Oleg Nesterov <oleg@...hat.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
"Nikita V. Youshchenko" <nyoushchenko@...sta.com>,
Matt Fleming <matt@...sole-pimps.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/7] signal: retarget_shared_pending: optimize
while_each_thread() loop
Hello,
More nitpicks.
On Mon, Apr 18, 2011 at 03:45:18PM +0200, Oleg Nesterov wrote:
> --- sigprocmask/kernel/signal.c~3_optimize_retarget_loop 2011-04-17 21:08:05.000000000 +0200
> +++ sigprocmask/kernel/signal.c 2011-04-17 21:28:21.000000000 +0200
> @@ -2033,8 +2033,18 @@ static void retarget_shared_pending(stru
>
> t = tsk;
> while_each_thread(tsk, t) {
> - if (!signal_pending(t) && !(t->flags & PF_EXITING))
> - recalc_sigpending_and_wake(t);
> + if ((t->flags & PF_EXITING))
Inner () unnecessary.
> + continue;
> + if (!has_pending_signals(&shared_pending, &t->blocked))
> + continue;
> +
> + sigandsets(&shared_pending, &shared_pending, &t->blocked);
> +
> + if (!signal_pending(t))
> + signal_wake_up(t, 0);
> +
> + if (sigisemptyset(&shared_pending))
> + break;
More comments, please. Other than that,
Acked-by: Tejun Heo <tj@...nel.org>
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists