| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <AFCDDB4A3EA003429EEF1E7B211FDBBA33954612EB@EXDCVYMBSTM005.EQ1STM.local>
Date: Tue, 26 Apr 2011 10:19:37 +0200
From: Par-Gunnar HJALMDAHL <par-gunnar.p.hjalmdahl@...ricsson.com>
To: Greg KH <greg@...ah.com>
Cc: Greg Kroah-Hartman <gregkh@...e.de>,
"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
Linus Walleij <linus.walleij@...aro.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
Pavan Savoy <pavan_savoy@...y.com>,
Vitaly Wool <vitalywool@...il.com>,
Alan Cox <alan@...rguk.ukuu.org.uk>,
Arnd Bergmann <arnd@...db.de>,
Marcel Holtmann <marcel@...tmann.org>,
Lukasz Rymanowski <Lukasz.Rymanowski@...to.com>,
Linus WALLEIJ <linus.walleij@...ricsson.com>,
Par-Gunnar Hjalmdahl <pghatwork@...il.com>,
Lee Jones <lee.jones@...aro.org>,
Mathieu Poirier <mathieu.poirier@...aro.org>
Subject: RE: [PATCH v4] staging: Add ST-Ericsson CG2900 driver
> -----Original Message-----
> From: Greg KH [mailto:greg@...ah.com]
> Sent: den 26 april 2011 01:53
>
> To have a patch accepted into the staging tree there are only 2 simple
> requirements:
> - proper license
> - code must build
>
> Somehow the second one fails here, please at least test-build your code
> before sending it out, to do otherwise just wastes people's time and
> makes them grumpy:
>
> CHK include/linux/version.h
> CHK include/generated/utsrelease.h
> CALL scripts/checksyscalls.sh
> CHK include/generated/compile.h
> CC [M] drivers/staging/cg2900/mfd/cg2900_chip.o
> drivers/staging/cg2900/mfd/cg2900_chip.c:2940:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2940:3: warning:
> initialization makes integer from pointer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2940:3: error: initializer
> element is not computable at load time
> drivers/staging/cg2900/mfd/cg2900_chip.c:2940:3: error: (near
> initialization for ‘cg2900_devs[0].id’)
> drivers/staging/cg2900/mfd/cg2900_chip.c:2941:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2941:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2945:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2945:3: warning:
> initialization makes integer from pointer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2945:3: error: initializer
> element is not computable at load time
> drivers/staging/cg2900/mfd/cg2900_chip.c:2945:3: error: (near
> initialization for ‘cg2900_devs[1].id’)
> drivers/staging/cg2900/mfd/cg2900_chip.c:2946:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2946:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2950:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2950:3: warning:
> initialization makes integer from pointer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2950:3: error: initializer
> element is not computable at load time
> drivers/staging/cg2900/mfd/cg2900_chip.c:2950:3: error: (near
> initialization for ‘cg2900_devs[2].id’)
> drivers/staging/cg2900/mfd/cg2900_chip.c:2951:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2951:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2955:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2955:3: warning:
> initialization makes integer from pointer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2955:3: error: initializer
> element is not computable at load time
> drivers/staging/cg2900/mfd/cg2900_chip.c:2955:3: error: (near
> initialization for ‘cg2900_devs[3].id’)
> drivers/staging/cg2900/mfd/cg2900_chip.c:2956:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2956:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2960:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2960:3: warning:
> initialization makes integer from pointer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2960:3: error: initializer
> element is not computable at load time
> drivers/staging/cg2900/mfd/cg2900_chip.c:2960:3: error: (near
> initialization for ‘cg2900_devs[4].id’)
> drivers/staging/cg2900/mfd/cg2900_chip.c:2961:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2961:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2965:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2965:3: warning:
> initialization makes integer from pointer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2965:3: error: initializer
> element is not computable at load time
> drivers/staging/cg2900/mfd/cg2900_chip.c:2965:3: error: (near
> initialization for ‘cg2900_devs[5].id’)
> drivers/staging/cg2900/mfd/cg2900_chip.c:2966:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2966:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2970:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2970:3: warning:
> initialization makes integer from pointer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2970:3: error: initializer
> element is not computable at load time
> drivers/staging/cg2900/mfd/cg2900_chip.c:2970:3: error: (near
> initialization for ‘cg2900_devs[6].id’)
> drivers/staging/cg2900/mfd/cg2900_chip.c:2971:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2971:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2975:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2975:3: warning:
> initialization makes integer from pointer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2975:3: error: initializer
> element is not computable at load time
> drivers/staging/cg2900/mfd/cg2900_chip.c:2975:3: error: (near
> initialization for ‘cg2900_devs[7].id’)
> drivers/staging/cg2900/mfd/cg2900_chip.c:2976:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2976:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2980:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2980:3: warning:
> initialization makes integer from pointer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2980:3: error: initializer
> element is not computable at load time
> drivers/staging/cg2900/mfd/cg2900_chip.c:2980:3: error: (near
> initialization for ‘cg2900_devs[8].id’)
> drivers/staging/cg2900/mfd/cg2900_chip.c:2981:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2981:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2985:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2985:3: warning:
> initialization makes integer from pointer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2985:3: error: initializer
> element is not computable at load time
> drivers/staging/cg2900/mfd/cg2900_chip.c:2985:3: error: (near
> initialization for ‘cg2900_devs[9].id’)
> drivers/staging/cg2900/mfd/cg2900_chip.c:2986:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2986:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2990:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2990:3: warning:
> initialization makes integer from pointer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2990:3: error: initializer
> element is not computable at load time
> drivers/staging/cg2900/mfd/cg2900_chip.c:2990:3: error: (near
> initialization for ‘cg2900_devs[10].id’)
> drivers/staging/cg2900/mfd/cg2900_chip.c:2991:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2991:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:3073:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3073:3: warning:
> initialization from incompatible pointer type
> drivers/staging/cg2900/mfd/cg2900_chip.c:3074:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3074:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:3079:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3079:3: warning:
> initialization from incompatible pointer type
> drivers/staging/cg2900/mfd/cg2900_chip.c:3080:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3080:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:3085:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3085:3: warning:
> initialization from incompatible pointer type
> drivers/staging/cg2900/mfd/cg2900_chip.c:3086:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3086:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:3091:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3091:3: warning:
> initialization from incompatible pointer type
> drivers/staging/cg2900/mfd/cg2900_chip.c:3092:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3092:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:3097:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3097:3: warning:
> initialization from incompatible pointer type
> drivers/staging/cg2900/mfd/cg2900_chip.c:3098:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3098:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:3103:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3103:3: warning:
> initialization from incompatible pointer type
> drivers/staging/cg2900/mfd/cg2900_chip.c:3104:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3104:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:3109:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3109:3: warning:
> initialization from incompatible pointer type
> drivers/staging/cg2900/mfd/cg2900_chip.c:3110:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3110:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:3115:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3115:3: warning:
> initialization from incompatible pointer type
> drivers/staging/cg2900/mfd/cg2900_chip.c:3116:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3116:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:3121:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3121:3: warning:
> initialization from incompatible pointer type
> drivers/staging/cg2900/mfd/cg2900_chip.c:3122:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3122:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:3127:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3127:3: warning:
> initialization from incompatible pointer type
> drivers/staging/cg2900/mfd/cg2900_chip.c:3128:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3128:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:3133:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3133:3: warning:
> initialization from incompatible pointer type
> drivers/staging/cg2900/mfd/cg2900_chip.c:3134:3: error: unknown field
> ‘data_size’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:3134:3: warning:
> initialization makes pointer from integer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c: In function ‘set_plat_data’:
> drivers/staging/cg2900/mfd/cg2900_chip.c:3147:41: error: ‘struct
> mfd_cell’ has no member named ‘platform_data’
> drivers/staging/cg2900/mfd/cg2900_chip.c:3147:37: warning:
> initialization from incompatible pointer type
> make[4]: *** [drivers/staging/cg2900/mfd/cg2900_chip.o] Error 1
> make[3]: *** [drivers/staging/cg2900/mfd] Error 2
> make[2]: *** [drivers/staging/cg2900] Error 2
> make[1]: *** [drivers/staging] Error 2
> make: *** [drivers] Error 2
>
>
> {sigh}
>
> Please redo this, I obviously can't accept it as-is.
>
> greg k-h
Hi Greg,
Sorry for all this trouble.
Of course I built the patches before sending them.
The problem is that the MFD core file has recently been updated and my
Linux base did not have this update included. I will update to latest
linux-next and correct the issue.
Trust me that I do not intentionally send patches that do not build.
Thanks,
/P-G
Powered by blists - more mailing lists