linux-kernel - Re: [PATCH 08/14] mfd: use platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110426094540.GC2659@sortiz-mobl>
Date:	Tue, 26 Apr 2011 11:45:41 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Haojian Zhuang <haojian.zhuang@...vell.com>
Cc:	haojian.zhuang@...il.com, linux-kernel@...r.kernel.org,
	lrg@...mlogic.co.uk, broonie@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 08/14] mfd: use platform_data in max8925

Hi Haojian,

On Wed, Apr 20, 2011 at 07:54:26PM +0800, Haojian Zhuang wrote:
> Use platform_data to pass parameters to client driver.
You need to provide more details about why this is needed, and how the sub
devices resources can change from one platform to another.

Also, some additional comments:


> +static struct resource bk_resources[] __devinitdata = {
> +	{0, 0, "max8925-backlight", IORESOURCE_IO,},
>  };
Do you really need to define this empty resource ? Can't you do that from the 
device_*_init() routines ?

> +static void __devinit device_bk_init(struct max8925_chip *chip,
> +				     struct i2c_client *i2c,
> +				     struct max8925_platform_data *pdata)
I don't think you need to pass the i2c pointer here.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/