linux-kernel - Re: [PATCH 06/14] mfd: pxa-w1: MFD driver for PXA 1wire control + DS1WM chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110426094836.GD2659@sortiz-mobl>
Date:	Tue, 26 Apr 2011 11:48:37 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Haojian Zhuang <haojian.zhuang@...vell.com>
Cc:	haojian.zhuang@...il.com, linux-kernel@...r.kernel.org,
	dmitry.torokhov@...il.com, a.zummo@...ertech.it,
	johnpol@....mipt.ru, cbou@...l.ru, dwmw2@...radead.org,
	lrg@...mlogic.co.uk, broonie@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 06/14] mfd: pxa-w1: MFD driver for PXA 1wire control +
 DS1WM chip

Hi Haojian,

On Mon, Apr 18, 2011 at 10:04:03PM +0800, Haojian Zhuang wrote:
> This driver provides registers and IRQ of PXA3xx chips to the ds1wm driver.
I see why this is needed, but I really think the ds1wm driver should be
converted to a regular platform device. The MFD driver below is just adding a
useless middle layer between your platform code and the ds1wm one.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/