linux-kernel - Re: [PATCH 029/173] pata_mpc52xx: inherit from ata_bmdma_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DB6A216.1010609@mvista.com>
Date:	Tue, 26 Apr 2011 14:44:38 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Willy Tarreau <w@....eu>
CC:	linux-kernel@...r.kernel.org, stable@...nel.org,
	stable-review@...nel.org, Tejun Heo <tj@...nel.org>,
	Jeff Garzik <jgarzik@...hat.com>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH 029/173] pata_mpc52xx: inherit from ata_bmdma_port_ops

Hello.

On 26-04-2011 0:03, Willy Tarreau wrote:

> 2.6.27.59-stable review patch.  If anyone has any objections, please let us know.

    DMA support was added to this driver only in 2.6.29, hence this patch is 
not needed in 2.6.27.y...

> ------------------

> From: Tejun Heo<tj@...nel.org>

> commit 77c5fd19075d299fe820bb59bb21b0b113676e20 upstream.

> pata_mpc52xx supports BMDMA but inherits ata_sff_port_ops which
> triggers BUG_ON() when a DMA command is issued.  Fix it.

> Signed-off-by: Tejun Heo<tj@...nel.org>
> Reported-by: Roman Fietze<roman.fietze@...emotive.de>
> Cc: Sergei Shtylyov<sshtylyov@...sta.com>
> Signed-off-by: Jeff Garzik<jgarzik@...hat.com>
> Signed-off-by: Greg Kroah-Hartman<gregkh@...e.de>

> ---
>   drivers/ata/pata_mpc52xx.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> --- a/drivers/ata/pata_mpc52xx.c
> +++ b/drivers/ata/pata_mpc52xx.c
> @@ -610,7 +610,7 @@ static struct scsi_host_template mpc52xx
>   };
>
>   static struct ata_port_operations mpc52xx_ata_port_ops = {
> -	.inherits		=&ata_sff_port_ops,
> +	.inherits		=&ata_bmdma_port_ops,
>   	.sff_dev_select		= mpc52xx_ata_dev_select,
>   	.set_piomode		= mpc52xx_ata_set_piomode,
>   	.set_dmamode		= mpc52xx_ata_set_dmamode,

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/