linux-kernel - Re: [PATCHv4 1/4] MFD: TPS65910: Add new mfd device for TPS65910

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110426140001.GA3175@sortiz-mobl>
Date:	Tue, 26 Apr 2011 16:00:02 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>
Cc:	linux-kernel@...r.kernel.org, broonie@...nsource.wolfsonmicro.com,
	lrg@...com, Graeme Gregory <gg@...mlogic.co.uk>
Subject: Re: [PATCHv4 1/4] MFD: TPS65910: Add new mfd device for TPS65910

Hi Jorge,

On Thu, Apr 21, 2011 at 09:35:43AM -0500, Jorge Eduardo Candelaria wrote:
> From: Graeme Gregory <gg@...mlogic.co.uk>
> 
> The TPS65910 chip is a power management IC for multimedia and handheld
> devices. It contains the following components:
The patch looks mostly good to me.
You may want to add a locked tps65910_set|clear_bits() API, since it seems
you're doing many read(reg), write(reg) sequences in the GPIO driver. That
could also be directly used by the regulator one.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/