linux-kernel - Re: [PM8921 MFD V5 0/6] pm8921 core and subdevices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110426154045.GG3175@sortiz-mobl>
Date:	Tue, 26 Apr 2011 17:40:46 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	Abhijeet Dharmapurikar <adharmap@...eaurora.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Linus Walleij <linux.walleij@...aro.org>,
	linux-arm-msm@...r.kernel.org,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org, Thomas Glexiner <tglx@...utronix.de>,
	Andres Salomon <dilinger@...ued.net>, dwalker@...o99.com,
	davidb@...eaurora.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PM8921 MFD V5 0/6] pm8921 core and subdevices

Hi Uwe,

On Tue, Apr 26, 2011 at 05:37:37PM +0200, Uwe Kleine-König wrote:
> Hi Samuel,
> 
> On Tue, Apr 26, 2011 at 05:07:47PM +0200, Samuel Ortiz wrote:
> > > - mfd_cell does not have platfrom_data anymore - use mfd data instead.
> > I'm currently moving that away from the mfd_cell structure, in my for-next
> > branch. mfd_cell now has a platform_data pointer back, and you should use
> > mfd_get_cell() if you really need to reach the mfd_cell pointer (which you
> > apparently don't). 
> > Could you please generate patchs 3 and 4 against this branch ?
> I just saw commit
> 
> 	5828fdb (mfd: Use mfd cell platform_data for mc13xxx cells platform bits)
> 
> in next. It has a Cc: for me, but I didn't got it by mail.
> 
> Did you send a mail and it didn't reach me? Or maybe you just forgot to
> send the mail out?
I haven't sent the patchset to lkml yet.


> Anyhow, Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> for
> 5828fdb, 
Thanks a lot.

> but I wonder if it's worth to add a new member to struct
> platform_device for that to work.
This has been discussed at length already, and it's probably the best solution
for now to clearly separate mfd cell access from the platform data bits.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/