linux-kernel - Re: [TRIVIAL PATCH] treewide: Cleanup continuations and remove logging message whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110426093434.e999ed24.randy.dunlap@oracle.com>
Date:	Tue, 26 Apr 2011 09:34:34 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Harry Wei <jiaweiwei.xiyou@...il.com>
Cc:	linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>,
	Jiri Kosina <trivial@...nel.org>
Subject: Re: [TRIVIAL PATCH] treewide: Cleanup continuations and remove
 logging message whitespace

On Tue, 26 Apr 2011 10:48:10 +0800 Harry Wei wrote:

> On Mon, Apr 25, 2011 at 08:22:30AM -0700, Randy Dunlap wrote:
> > On Sat, 23 Apr 2011 20:38:19 -0700 Joe Perches wrote:
> > 
> > > Using C line continuation inside format strings is error prone.
> > > Clean up the unintended whitespace introduced by misuse of \.
> > > Neaten correctly used line continations as well for consistency.
> > > 
> > > drivers/scsi/arcmsr/arcmsr_hba.c has these errors as well,
> > > but arcmsr needs a lot more work and the driver should likely be
> > > moved to staging instead.
> > > 
> > > Signed-off-by: Joe Perches <joe@...ches.com>
> >
> Acked-by: Harry Wei <harryxiyou@...il.com>
> > 
> > 
> > Joe,
> > Is there a decent fix for this warning in linux-next:
> > 
> > drivers/tty/n_gsm.c:535: warning: zero-length gnu_printf format string
> Hi Randy & Joe,
>    I have seen the drivers/tty/n_gsm.c. 
> From line 529 to line 540 in drivers/tty/n_gsm.c like following.
> 
> 529 static void hex_packet(const unsigned char *p, int len)
> 530 {
> 531	int i;
> 532	for (i = 0; i < len; i++) {
> 533		if (i && (i % 16) == 0) {
> 534			pr_cont("\n");
> 535			pr_debug("");                                                                      
> 536		}
> 537		pr_cont("%02X ", *p++);
> 538	}
> 539	pr_cont("\n");
> 540 }
> 
> Should we need the line 535? If true, i wanna the function of 
> 'pr_debug("");'

Hi Harry,

Joe sent a different patch for this warning message.

thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/