linux-kernel - Re: [PATCH] linux/string.h: Introduce streq macro.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1303845900.18763.34.camel@gandalf.stny.rr.com>
Date:	Tue, 26 Apr 2011 15:25:00 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Thiago Farina <tfransosi@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] linux/string.h: Introduce streq macro.

On Tue, 2011-04-26 at 22:20 +0300, Alexey Dobriyan wrote:
> On Tue, Apr 26, 2011 at 03:17:48PM -0400, Steven Rostedt wrote:
> > On Tue, 2011-04-26 at 22:05 +0300, Alexey Dobriyan wrote:
> > > On Tue, Apr 26, 2011 at 03:49:49PM -0300, Thiago Farina wrote:
> 
> > > >  /**
> > > > + * streq - Are two strings equal?
> > > > + * @a: first string
> > > > + * @b: second string
> > > > + *
> > > > + * Example:
> > > > + *	if (streq(argv[1], "--help"))
> > > > + *		printf("%s\n", "This help");
> > 
> > Userspace example?
> 
> The point is that function is trivial, and if someone doesn't
> understand it, he should read some Kernighan and Ritchie first.

I understood your point, but I missed looking at it in my first reply.
I'm just stating that it is even worse since it includes a userspace
example of a macro defined in the kernel. IOW, the example wont even
work.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/