linux-kernel - Re: [PATCH 2/6] dmaengine/dw_dmac: Enable resubmission from callback routine.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110426203136.GB17290@n2100.arm.linux.org.uk>
Date:	Tue, 26 Apr 2011 21:31:36 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	"Koul, Vinod" <vinod.koul@...el.com>
Cc:	Viresh Kumar <viresh.kumar@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Williams, Dan J" <dan.j.williams@...el.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"armando.visconti@...com" <armando.visconti@...com>,
	"shiraz.hashim@...com" <shiraz.hashim@...com>,
	"amit.goel@...com" <amit.goel@...com>,
	"viresh.linux@...il.com" <viresh.linux@...il.com>,
	"jamie@...ieiles.com" <jamie@...ieiles.com>
Subject: Re: [PATCH 2/6] dmaengine/dw_dmac: Enable resubmission from
	callback routine.

On Tue, Apr 19, 2011 at 11:42:24AM +0530, Koul, Vinod wrote:
> On 04/18/2011 04:20 PM, viresh kumar wrote:
> > 
> > Resubmission of new transfer must be allowed from callbacks. For this release
> > lock before calling callback routine and enable them again.
> Why would you like to do that?
> 
> IMO it's not a good thing as you are essentially doing it in your tasklet...
> Make sure the submit() is done by client before this and you use it to start
> next transaction in you tasklet and let client know in callback txn is
> finished.

No.  Submission is explicitly permitted (by Dan) in slave DMA callbacks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/