linux-kernel - Re: [PATCH] kbuild: don't warn about linux/version.h not including itself

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4DB72C9F.50401@suse.cz>
Date:	Tue, 26 Apr 2011 22:35:43 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	pefoley2@...izon.net
Cc:	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] kbuild: don't warn about linux/version.h not including
 itself

On 25.4.2011 01:27, Peter Foley wrote:
> This patch makes checkversion.pl not warn that include/linux/version.h
> dosen't include itself.
> 
> Signed-off-by: Peter Foley <pefoley2@...izon.net>
> ---
>  scripts/checkversion.pl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/checkversion.pl b/scripts/checkversion.pl
> index b444e89..b9150c7 100755
> --- a/scripts/checkversion.pl
> +++ b/scripts/checkversion.pl
> @@ -47,7 +47,7 @@ foreach my $file (@ARGV) {
>      }
>  
>      # Report used version IDs without include?
> -    if ($fUseVersion && ! $iLinuxVersion) {
> +    if ($fUseVersion && ! $iLinuxVersion && $file !~ "include/linux/version.h") {

A more obvious fix would be to check the filename right at the beginning
of the loop and skip to the next iteration if it is version.h. Also, you
should escape the '.' in the regexp.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/