linux-kernel - Re: [PATCH 3/3] flex_array: allow 0 length elements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1303850780.9308.17380.camel@nimitz>
Date:	Tue, 26 Apr 2011 13:46:20 -0700
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	Eric Paris <eparis@...hat.com>
Cc:	steffen.klassert@...unet.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, selinux@...ho.nsa.gov,
	sds@...ho.nsa.gov
Subject: Re: [PATCH 3/3] flex_array: allow 0 length elements

On Mon, 2011-04-25 at 21:45 -0400, Eric Paris wrote:
> allow elements of 0 length.  We already allow flex_arrays with 0
> elements, but
> this patch allow us to have elements that are 0 bytes long.
> 
> Based-on-patch-by: Steffen Klassert <steffen.klassert@...unet.com>
> Signed-off-by: Eric Paris <eparis@...hat.com> 

I'd like to see a bit of the history in the changelog.  kmalloc(0)
returns NULL, and we'd effectively like to do the same since flex_arrays
really are like a mini allocator.  The 0-sized elements come from
userspace and we *have* to handle them in the security code, etc...

The code looks good, though.

Acked-by: Dave Hansen <dave@...ux.vnet.ibm.com>

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/