linux-kernel - Re: [PATCH] Staging: xgifb: Fixed style issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1303791692.24299.23.camel@Joe-Laptop>
Date:	Mon, 25 Apr 2011 21:21:32 -0700
From:	Joe Perches <joe@...ches.com>
To:	Kenji Toyama <kenji.toyama@...il.com>
Cc:	gregkh@...e.de, aaro.koskinen@....fi, wfp5p@...ginia.edu,
	martinez.javier@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: xgifb: Fixed style issues.

On Tue, 2011-04-26 at 12:12 +0800, Kenji Toyama wrote:
> Now there's only 10 errors and 1 warning given by checkpatch.pl, and
> these are related initialization of statics. The only warning left can
> be safely ignored I believe.
[]
>  static DEFINE_PCI_DEVICE_TABLE(xgifb_pci_table) = {
> -	{ PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_20, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> -	{ PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_27, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
> -	{ PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_40, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 2},
> -	{ PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_42, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 3},
> -	{ 0 }
> +	{PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_20, PCI_ANY_ID, PCI_ANY_ID,
> +	 0, 0, 0},
> +	{PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_27, PCI_ANY_ID, PCI_ANY_ID,
> +	 0, 0, 1},
> +	{PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_40, PCI_ANY_ID, PCI_ANY_ID,
> +	 0, 0, 2},
> +	{PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_42, PCI_ANY_ID, PCI_ANY_ID,
> +	 0, 0, 3},
> +	{0}

Not an improvement.
You might use PCI_VDEVICE.
>  #define MODE_INDEX_NONE           0  /* TW: index for mode=none */
> -	{"none",         0xFF, 0x0000, 0x0000,    0,    0,  0, 0,   0,  0, MD_XGI300|MD_XGI315},  /* TW: for mode "none" */
[]
> +	{"none",         0xFF, 0x0000, 0x0000,    0,    0,  0, 0,   0,  0,
> +	 MD_XGI300|MD_XGI315},  /* TW: for mode "none" */

Again, not an improvement.
Not everything needs to be 80 columns.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/