linux-kernel - Re: [PATCH v4 03/11] da850: pruss platform specific additions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DB7EA5E.7000507@mvista.com>
Date:	Wed, 27 Apr 2011 14:05:18 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Subhasish Ghosh <subhasish@...tralsolutions.com>
CC:	davinci-linux-open-source@...ux.davincidsp.com,
	linux-arm-kernel@...ts.infradead.org, m-watkins@...com,
	nsekhar@...com, sachi@...tralsolutions.com,
	"Kevin Hilman \(supporter:TI DAVINCI MACHIN...,commit_signer:15/17=88%\)" 
	<khilman@...com>,
	"Russell King (maintainer:ARM PORT)" <linux@....linux.org.uk>,
	"Michael Williamson (commit_signer:6/17=35%)" 
	<michael.williamson@...ticallink.com>,
	"Cyril Chemparathy (commit_signer:3/17=18%)" <cyril@...com>,
	"Sergei Shtylyov (commit_signer:2/17=12%)" <sshtylyov@...mvista.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 03/11] da850: pruss platform specific additions.

Hello.

On 27-04-2011 10:43, Subhasish Ghosh wrote:

>>> #include<mach/edma.h>
>>> @@ -73,6 +75,7 @@ extern unsigned int da850_max_speed;
>>> #define DA8XX_DDR2_CTL_BASE 0xb0000000
>>> #define DA8XX_ARM_RAM_BASE 0xffff0000
>>> #define DA8XX_SHARED_RAM_BASE 0x80000000
>>> +#define DA8XX_PRUSS_MEM_BASE 0x01C30000

>> Keep the list sorted please. Also, this macro doesn't seem used outside
>> devices-da8xx.c, so should be moved there...

> SG - But would it not be better to have all device addresses at the same place.

    They are not at the same place already -- which is intentional. The ones 
used locally in devices-da8xx.c should be #define'd there.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/