linux-kernel - Re: [PATCH] kconfig: Avoid buffer underrun in choice input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DB7FBD8.20109@suse.cz>
Date:	Wed, 27 Apr 2011 13:19:52 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-kbuild@...r.kernel.org, Roman Zippel <zippel@...ux-m68k.org>
Subject: Re: [PATCH] kconfig: Avoid buffer underrun in choice input

On 23.4.2011 19:42, Ben Hutchings wrote:
> commit 40aee729b350672c2550640622416a855e27938f ('kconfig: fix default
> value for choice input') fixed some cases where kconfig would select
> the wrong option from a choice with a single valid option and thus
> enter an infinite loop.
>
> However, this broke the test for user input of the form 'N?', because
> when kconfig selects the single valid option the input is zero-length
> and the test will read the byte before the input buffer.  If this
> happens to contain '?' (as it will in a mips build on Debian unstable
> today) then kconfig again enters an infinite loop.
>
> Signed-off-by: Ben Hutchings<ben@...adent.org.uk>
> Cc: stable@...nel.org [2.6.17+]
> ---
> Roman has failed to respond to this after 5 weeks and one reminder, so
> please take it directly.

I applied this on 8th April, see
http://www.spinics.net/lists/linux-kbuild/msg04431.html. Please check 
linux-next before reposting patches next time, now I either have to 
rewind the kconfig branch or let Linus merge it with a duplicate commit :-(.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/