linux-kernel - Re: [PATCH 1/8] staging/mei: PCI device and char driver support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DB80B15.6050502@gmail.com>
Date:	Wed, 27 Apr 2011 14:24:53 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Oren Weil <oren.jer.weil@...el.com>
CC:	gregkh@...e.de, devel@...verdev.osuosl.org, david@...dhou.se,
	linux-kernel@...r.kernel.org, alan@...ux.intel.com
Subject: Re: [PATCH 1/8] staging/mei: PCI device and char driver support.

On 04/27/2011 12:27 PM, Oren Weil wrote:
> +	dev->mem_addr = pci_iomap(pdev, 0, 0);
...
> +	iounmap(dev->mem_addr);
...
> +	if (dev->mem_addr)
> +		iounmap(dev->mem_addr);

Just what I noticed after a quick look: you shall use pci_iounmap for
pci_iomap'ped space.

regards,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/