linux-kernel - Re: [PATCH 7/8] staging/mei: AMT Watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110427150738.GE24596@suse.de>
Date:	Wed, 27 Apr 2011 08:07:38 -0700
From:	Greg KH <gregkh@...e.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Oren Weil <oren.jer.weil@...el.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, alan@...ux.intel.com,
	david@...dhou.se
Subject: Re: [PATCH 7/8] staging/mei: AMT Watchdog

On Wed, Apr 27, 2011 at 03:53:01PM +0200, Arnd Bergmann wrote:
> On Wednesday 27 April 2011, Oren Weil wrote:
> > 
> > code that open connection and invoke
> > heartbeats to the AMT Watchdog client/feature, if exists
> > 
> > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> > Signed-off-by: Itzhak Tzeel-Krupp <itzhak.tzeel-krupp@...el.com>
> > Signed-off-by: Oren Weil <oren.jer.weil@...el.com>
> 
> I still think this should be a regular watchdog driver using
> the drivers/watchdog user interface.

I agree, Oren, if you are going to insist on doing things this way, you
had better describe _why_ you are ignoring the existing kernel
interfaces provided.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/