[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110427183616.GL6027@google.com>
Date: Wed, 27 Apr 2011 11:36:16 -0700
From: Mandeep Singh Baines <msb@...gle.com>
To: Jeff Mahoney <jeffm@...e.com>
Cc: Ingo Molnar <mingo@...e.hu>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] hung_task_timeout: configurable default
Jeff Mahoney (jeffm@...e.com) wrote:
> This patch allows the default value for sysctl_hung_task_timeout_secs
> to be set at build time. The feature carries virtually no overhead,
> so it makes sense to keep it enabled. On heavily loaded systems, though,
> it can end up triggering stack traces when there is no bug other than
> the system being underprovisioned. We use this patch to keep the hung task
> facility available but disabled at boot-time.
>
Clever.
> The default of 120 seconds is preserved. As a note, commit e162b39a may
> have accidentally reverted commit fb822db4, which raised the default from
> 120 seconds to 480 seconds.
>
> Signed-off-by: Jeff Mahoney <jeffm@...e.com>
Acked-by: Mandeep Singh Baines <msb@...gle.com>
> ---
> kernel/hung_task.c | 3 ++-
> lib/Kconfig.debug | 14 ++++++++++++++
> 2 files changed, 16 insertions(+), 1 deletion(-)
>
> --- a/kernel/hung_task.c
> +++ b/kernel/hung_task.c
> @@ -33,7 +33,8 @@ unsigned long __read_mostly sysctl_hung_
> /*
> * Zero means infinite timeout - no checking done:
> */
> -unsigned long __read_mostly sysctl_hung_task_timeout_secs = 120;
> +unsigned long __read_mostly sysctl_hung_task_timeout_secs =
> + CONFIG_DEFAULT_HUNG_TASK_TIMEOUT;
>
> unsigned long __read_mostly sysctl_hung_task_warnings = 10;
>
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -214,6 +214,20 @@ config DETECT_HUNG_TASK
> enabled then all held locks will also be reported. This
> feature has negligible overhead.
>
> +config DEFAULT_HUNG_TASK_TIMEOUT
> + int "Default timeout for hung task detection (in seconds)"
> + depends on DETECT_HUNG_TASK
> + default 120
> + help
> + This option controls the default timeout (in seconds) used
> + to determine when a task has become non-responsive and should
> + be considered hung.
> +
> + It can be adjusted at runtime via the kernel.hung_task_timeout
> + sysctl or by writing a value to /proc/sys/kernel/hung_task_timeout.
> +
> + A timeout of 0 disables the check. The default is 120 seconds.
> +
> config BOOTPARAM_HUNG_TASK_PANIC
> bool "Panic (Reboot) On Hung Tasks"
> depends on DETECT_HUNG_TASK
> --
> Jeff Mahoney
> SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists