linux-kernel - Re: [PATCH v3.2] kbuild: implement several W= levels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110427204607.GA9005@merkur.ravnborg.org>
Date:	Wed, 27 Apr 2011 22:46:07 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Borislav Petkov <bp@...en8.de>, Michal Marek <mmarek@...e.cz>,
	linux-kbuild <linux-kbuild@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Dave Jones <davej@...hat.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH v3.2] kbuild: implement several W= levels

On Wed, Apr 27, 2011 at 01:21:00PM -0700, Joe Perches wrote:
> On Wed, 2011-04-27 at 22:15 +0200, Borislav Petkov wrote:
> > From: Sam Ravnborg <sam@...nborg.org>
> []
> > +warning-1 += -Wold-style-definition
> > +warning-1 += $(call cc-option, -Wmissing-include-dirs)
> 
> Only thing I would suggest is a comment describing why
> some entries use $(call cc-option, -Wfoo) and others don't.
> 
> Something akin to:
> 
> # Use call cc-option when the minimum supported gcc version does not
> # support a specific option but a later gcc version does.

>From the patch:
+# $(call cc-option, -W...) handles gcc -W.. options which
 # are not supported by all versions of the compiler

So it is already included.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/