linux-kernel - Re: [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTikc7B5J0Z_aiS5kXCxMSxcFrfSRxw@mail.gmail.com>
Date:	Thu, 28 Apr 2011 09:07:33 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>,
	Grant Likely <grant.likely@...retlab.ca>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Lee Jones <lee.jones@...aro.org>,
	Jonas Aaberg <jonas.aberg@...ricsson.com>
Subject: Re: [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio

2011/4/27 H Hartley Sweeten <hartleys@...ionengravers.com>:
> On Wednesday, April 27, 2011 6:13 AM, Linus Walleij wrote:
>> From: Linus Walleij <linus.walleij@...aro.org>
>>
>> This rewrites the U300 GPIO driver using gpiolib and the irq_chip
>> abstractions, makes it runtime-configured rather than compile-time,
>> and moves it to the drivers/gpio subsystem where it belongs,
>> depopulating the ARM tree of one more driver.
>>
>> Cc: Jonas Aaberg <jonas.aberg@...ricsson.com>
>> Acked-by: Arnd Bergmann <arnd@...db.de>
>> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
>
> If this and other platform-specific GPIO drivers are going to be
> moved to the drivers/gpio subsystem, the Kconfig and Makefile should
> probably be updated to reflect this.
>
> In drivers/gpio/Kconfig:
>
> #
> # platform-neutral GPIO infrastructure and expanders
> #
>
> And in drivers/gpio/Makefile:
>
> # generic gpio support: dedicated expander chips, etc
> #
> # NOTE: platform-specific GPIO drivers don't belong in the
> # drivers/gpio directory; put them with other platform setup
> # code, IRQ controllers, board init, etc.

Yeah, you're right. I can take these comments out, simply.
I'll review the files as bit to make sure there aren't any more
statements like that.

> The Makefile should probably be reordered, either alphabetically
> or grouped by type (arch/mmio/i2c/spi/pci/etc) and then
> alphabetically in order to reduce merge conflicts.

Yes, but if I do that in my patchset I will screw up Grants GPIO tree
completely, so I prefer that Grant do this. And maybe after pulling
in my GPIO consolidation tree to his in that case, so we don't get
undesired collisions. So leaving this for the GPIO maintainer.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/