[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1303979556-30494-2-git-send-email-lifongsun@gmail.com>
Date: Thu, 28 Apr 2011 16:32:36 +0800
From: Lifeng Sun <lifongsun@...il.com>
To: Alan Cox <alan@...rguk.ukuu.org.uk>
Cc: linux-kernel@...r.kernel.org, Lifeng Sun <lifongsun@...il.com>
Subject: [PATCH 5/5] drivers/char/applicom.c: ac_ioctl should not always returns 0
It should return error code properly instead of always returning 0.
This driver does not seem to be actively maintained from my brief
investigation. Apologies to the maintainers that I have missed.
Signed-off-by: Lifeng Sun <lifongsun@...il.com>
---
drivers/char/applicom.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/applicom.c b/drivers/char/applicom.c
index 25373df..50c09e4 100644
--- a/drivers/char/applicom.c
+++ b/drivers/char/applicom.c
@@ -838,6 +838,6 @@ static long ac_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
Dummy = readb(apbs[IndexCard].RamIO + VERS);
kfree(adgl);
mutex_unlock(&ac_mutex);
- return 0;
+ return ret;
}
--
1.7.5.rc1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists