linux-kernel - Re: [PATCH 1/2] rcu: export rcu_note_context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DB93AE0.4050303@redhat.com>
Date:	Thu, 28 Apr 2011 13:01:04 +0300
From:	Avi Kivity <avi@...hat.com>
To:	Gleb Natapov <gleb@...hat.com>
CC:	linux-kernel@...r.kernel.org, paulmck@...ux.vnet.ibm.com,
	mtosatti@...hat.com, kvm@...r.kernel.org
Subject: Re: [PATCH 1/2] rcu: export rcu_note_context_switch() function

On 04/28/2011 12:52 PM, Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov<gleb@...hat.com>
> @@ -93,11 +93,7 @@ static inline int rcu_needs_cpu(int cpu)
>
>   #endif /* #else #ifdef CONFIG_TINY_RCU */
>
> -static inline void rcu_note_context_switch(int cpu)
> -{
> -	rcu_sched_qs(cpu);
> -	rcu_preempt_note_context_switch();
> -}
> +extern void rcu_note_context_switch(int cpu);
>

Why are you uninlining this function?  Why not export the two functions 
it calls instead?

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/