linux-kernel - Re: [PATCH] x86, efi: Only print warning when desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110428130545.GA14075@srcf.ucam.org>
Date:	Thu, 28 Apr 2011 14:05:45 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Matt Fleming <matt@...sole-pimps.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Huang Ying <ying.huang@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86, efi: Only print warning when desc_size is smaller
 than defined one.

On Wed, Apr 27, 2011 at 10:22:25AM -0700, Yinghai Lu wrote:

> 1. bootloader aka grub.efi will convert efi memmap to e820 memmap and pass it in boot params.
>    and current grub.efi does not compare desc_size and struct size.

So we'll already have crashed and burned before we got here, and so this 
check will never fire. I sent a patch to just remove the message on the 
28th of March.

There's no way someody could ship a system with a desc_size that's 
smaller than sizeof(memdesc). It wouldn't boot anything.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/