linux-kernel - Re: [PATCH 1/8] staging/mei: PCI device and char driver support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110428133745.GA4861@suse.de>
Date:	Thu, 28 Apr 2011 06:37:45 -0700
From:	Greg KH <gregkh@...e.de>
To:	"Weil, Oren jer" <oren.jer.weil@...el.com>
Cc:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alan@...ux.intel.com" <alan@...ux.intel.com>,
	"david@...dhou.se" <david@...dhou.se>
Subject: Re: [PATCH 1/8] staging/mei: PCI device and char driver support.

On Thu, Apr 28, 2011 at 08:47:04AM +0300, Weil, Oren jer wrote:
> >On Wed, Apr 27, 2011 at 01:27:30PM +0300, Oren Weil wrote:
> >> contains module entries and PCI driver and char device definitions
> >> (using file_operations, pci_driver structs).
> >
> >That's a very lame description.  Please be more verbous, like you did on
> the
> >0/8 patch, that explains what this code is and how it is accessed.
> >
> >Same goes for the other patches in this series, you need to explain things
> >more.
> 
> No problem, should I got into details in the patch description? 

Yes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/