linux-kernel - Re: [PATCH 6/8] staging/mei: Header file contain the Userland API, (IOCTL and its struct)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110428134036.GC4861@suse.de>
Date:	Thu, 28 Apr 2011 06:40:36 -0700
From:	Greg KH <gregkh@...e.de>
To:	"Weil, Oren jer" <oren.jer.weil@...el.com>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alan@...ux.intel.com" <alan@...ux.intel.com>,
	"david@...dhou.se" <david@...dhou.se>
Subject: Re: [PATCH 6/8] staging/mei: Header file contain the Userland API,
 (IOCTL and its struct)

On Thu, Apr 28, 2011 at 09:29:05AM +0300, Weil, Oren jer wrote:
> 
> >From: Greg KH [mailto:gregkh@...e.de]
> >On Wed, Apr 27, 2011 at 08:15:41AM -0700, Randy Dunlap wrote:
> >> Please update Documentation/ioctl/ioctl-number.txt.
> >
> >Not yet, this code might get that ioctl removed before it gets merged into 
> >the
> >main part of the kernel.
> >
> >Or at least I can hope :)
> 
> We discuss this IOCTL issue with Alan C. and David W. and I didn't see any 
> other solution for this.

Was this discussed in public?

> if someone has a good solution for that we are happy to hear it.

Did you rule out sysfs, configfs, netlink, etc.?

> the reason that we use IOCTL is that we need to "associate" (Connect)
> the current file description to a FW Client/Feature.  (opening a comm
> channel) .

As you didn't document this ioctl interface anywhere, saying exactly
what you are trying to do, it makes it a bit hard to review your
existing interface to determine that ioctls are the correct thing for
your device.

Care to document it, or at least describe it in the patches somewhere so
we know it and can properly review it?

> and in addition there is a security issue that we would like limit the access 
> to mei driver to system admins.
> 
> From what I read we can't get those requirements with Netlinks, right?
> If there other methods for achieving this ?

sysfs, configfs, your own filesystem, etc.  There are lots of options.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/