linux-kernel - Re: [PATCH] staging: r8712u: Fix driver to support ad-hoc mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DB9884F.10409@lwfinger.net>
Date:	Thu, 28 Apr 2011 10:31:27 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	clemens fischer <ino-news@...tteswoode.dnsalias.org>
CC:	Greg Kroah-Hartman <gregkh@...e.de>, jeff.chua.linux@...il.com,
	wlanfae@...ltek.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8712u: Fix driver to support ad-hoc mode

On 04/28/2011 10:08 AM, clemens fischer wrote:
>> Larry Finger:
>
>> From: Jeff Chua<jeff.chua.linux@...il.com>
>>
>> Driver r8712u is unable to handle ad-hoc mode. The issue is that when
>> the driver first starts, there will not be an SSID for association.
>> The fix is to always call the "select and join from scan" routine when
>> in ad-hoc mode.
>>
>> Note: Ad-hoc mode worked intermittently before. If the driver had
>> previously been associated, then things were OK.
>>
>> Signed-off-by: Jeff Chua<jeff.chua.linux@...il.com>
>> Signed-off-by: Larry Finger<Larry.Finger@...inger.net>
>> Cc: Stable<stable@...nel.org>
>> ---
>>
>> Index: linux-2.6/drivers/staging/rtl8712/rtl871x_ioctl_set.c
>> ===================================================================
>> --- linux-2.6.orig/drivers/staging/rtl8712/rtl871x_ioctl_set.c
>> +++ linux-2.6/drivers/staging/rtl8712/rtl871x_ioctl_set.c
>> @@ -68,7 +68,10 @@ static u8 do_join(struct _adapter *padap
>>   	pmlmepriv->fw_state |= _FW_UNDER_LINKING;
>>   	pmlmepriv->pscanned = plist;
>>   	pmlmepriv->to_join = true;
>> -	if (_queue_empty(queue) == true) {
>> +
>> +	/* adhoc mode will start with an empty queue, but skip checking */
>> +	if (!check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)&&
>> +	    _queue_empty(queue)) {
>>   		if (pmlmepriv->fw_state&  _FW_UNDER_LINKING)
>>   			pmlmepriv->fw_state ^= _FW_UNDER_LINKING;
>>   		/* when set_ssid/set_bssid for do_join(), but scanning queue
>
> Thanks for CC'ing me.
>
> This patch doesn't solve my problem[1], unfortunately.  I am using
> iwconfig(8) to setup things, and it is still impossible to set the ESSID
> and the power saving mode.  In my case it was even possible to get into
> Ad-hoc mode without the patch and without ever beeing associated.
>
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=33352

Does this one help? It should be in addition to the previous patch.

Larry

View attachment "r8712u_set_essid" of type "text/plain" (846 bytes)