linux-kernel - Re: [PATCH] s390: convert old cpumask API into new one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110429004726.3D83.A69D9226@jp.fujitsu.com>
Date:	Fri, 29 Apr 2011 00:45:47 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Thiago Farina <tfransosi@...il.com>
Cc:	kosaki.motohiro@...fujitsu.com,
	LKML <linux-kernel@...r.kernel.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux390@...ibm.com, linux-s390@...r.kernel.org
Subject: Re: [PATCH] s390: convert old cpumask API into new one

> > @@ -1016,21 +1016,21 @@ int __ref smp_rescan_cpus(void)
> >
> >        get_online_cpus();
> >        mutex_lock(&smp_cpu_state_mutex);
> > -       newcpus = cpu_present_map;
> > +       cpumask_copy(&newcpus, cpu_present_mask);
> >        rc = __smp_rescan_cpus();
> >        if (rc)
> >                goto out;
> > -       cpus_andnot(newcpus, cpu_present_map, newcpus);
> > -       for_each_cpu_mask(cpu, newcpus) {
> > +       cpumask_andnot(&newcpus, cpu_present_mask, &newcpus);
> > +       for_each_cpu(cpu,&newcpus) {
> please, could you add a space between cpu and ,&newcpus?

Thank you for finding.



>From 46812a238d85243a18dcec0749ba42d5f1a0e1ab Mon Sep 17 00:00:00 2001
From: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Date: Fri, 29 Apr 2011 00:44:43 +0900
Subject: [PATCH] s390: coding style fix

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
---
 arch/s390/kernel/smp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c
index 4cc09b8..a80798b 100644
--- a/arch/s390/kernel/smp.c
+++ b/arch/s390/kernel/smp.c
@@ -1021,7 +1021,7 @@ int __ref smp_rescan_cpus(void)
 	if (rc)
 		goto out;
 	cpumask_andnot(&newcpus, cpu_present_mask, &newcpus);
-	for_each_cpu(cpu,&newcpus) {
+	for_each_cpu(cpu, &newcpus) {
 		rc = smp_add_present_cpu(cpu);
 		if (rc)
 			set_cpu_present(cpu, false);
-- 
1.7.3.1



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/