linux-kernel - Re: linux-next: ibmveth runtime errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110428121124.39c036ff.sfr@canb.auug.org.au>
Date:	Thu, 28 Apr 2011 12:11:24 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:	ppc-dev <linuxppc-dev@...ts.ozlabs.org>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Santiago Leon <santil@...ux.vnet.ibm.com>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: ibmveth runtime errors

Hi Michał,

On Wed, 27 Apr 2011 12:36:22 +0200 Michał Mirosław <mirq-linux@...e.qmqm.pl> wrote:
>
> Please test the following patch. It's just a blind guess, as this error
> is not descriptive.
> 
> Best Regards,
> Michał Mirosław
> 
> ---
> 
> net: ibmveth: force reconfiguring checksum settings on startup
> 
> Commit b9367bf3ee6d ("net: ibmveth: convert to hw_features") accidentally
> removed call to ibmveth_set_csum_offload() in ibmveth_probe(). Put the
> call back where it was, but with additional error checking provided
> by ibmveth_set_features().
> 
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> 
> ---
>  drivers/net/ibmveth.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c
> index 4855f1f..0d1fea2 100644
> --- a/drivers/net/ibmveth.c
> +++ b/drivers/net/ibmveth.c
> @@ -1397,6 +1397,8 @@ static int __devinit ibmveth_probe(struct vio_dev *dev,
>  
>  	netdev_dbg(netdev, "registering netdev...\n");
>  
> +	ibmveth_set_features(dev, dev->features);
> +
>  	rc = register_netdev(netdev);
>  
>  	if (rc) {

This worked after I changed both "dev"s to "netdev".  And the boot
succedded.  I will apply this patchg to linux-next today and hopefully
Dave can apply it to the net tree.  I have added a copy fo the patch I
used below.

From: =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@...e.qmqm.pl>
Date: Thu, 28 Apr 2011 11:59:15 +1000
Subject: [PATCH] net: ibmveth: force reconfiguring checksum settings on
 startup
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Commit b9367bf3ee6d ("net: ibmveth: convert to hw_features") accidentally
removed call to ibmveth_set_csum_offload() in ibmveth_probe(). Put the
call back where it was, but with additional error checking provided
by ibmveth_set_features().

Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
[sfr: dev -> netdev]
Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 drivers/net/ibmveth.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c
index 4855f1f..be3fe71 100644
--- a/drivers/net/ibmveth.c
+++ b/drivers/net/ibmveth.c
@@ -1397,6 +1397,8 @@ static int __devinit ibmveth_probe(struct vio_dev *dev,
 
 	netdev_dbg(netdev, "registering netdev...\n");
 
+	ibmveth_set_features(netdev, netdev->features);
+
 	rc = register_netdev(netdev);
 
 	if (rc) {
-- 
1.7.4.4

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/